You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/18 07:51:32 UTC

[GitHub] [spark] sarutak edited a comment on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

sarutak edited a comment on pull request #31569:
URL: https://github.com/apache/spark/pull/31569#issuecomment-781129315


   I don't think it's worth replacing `'` with `col` or `$""` for the test code and some tests seem to check the `'` syntax itself.
   But it's OK for the following non-test code.
   
   * SimpleTypedAggregator.scala
   * SubExprEliminationBenchmark.scala
   * RangeBenchmark.scala
   * JsonBenchmark.scala


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org