[GitHub] [drill] cgivre edited a comment on pull request #2084: DRILL-7745: Add storage plugin for IPFS

[GitBox <gi...@apache.org>]

cgivre edited a comment on pull request #2084:
URL: https://github.com/apache/drill/pull/2084#issuecomment-674957594


   @dbw9580 
   This is looking pretty good. I'm going to do a final check this evening or tomorrow, but can you please:
   
   1.  Squash all commits and add message of `DRILL-7745: Add storage plugin for IPFS` as the commit message
   2.  Go through and do a final code hygiene check (make sure there are no extra spaces, commented out blocks etc). Drill does have a code formatter[1] and just verify that the code complies with the coding standards for spacing and all that.  (I didn't see anything jump out at me, but it always helps to double check)
   3.  Please create a JIRA to add this to the public documentation.  You're welcome to actually add the documentation as well, but for now, let's just make sure we have a JIRA on file to actually add the docs. 
   
   Thanks!
   
   [1]: https://drill.apache.org/docs/apache-drill-contribution-guidelines/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org