You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by fe...@apache.org on 2011/09/21 15:24:34 UTC

svn commit: r1173621 - /james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/SMTPMessage.java

Author: felixk
Date: Wed Sep 21 13:24:34 2011
New Revision: 1173621

URL: http://svn.apache.org/viewvc?rev=1173621&view=rev
Log:
Don't concatenate strings using + in a loop

Modified:
    james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/SMTPMessage.java

Modified: james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/SMTPMessage.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/SMTPMessage.java?rev=1173621&r1=1173620&r2=1173621&view=diff
==============================================================================
--- james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/SMTPMessage.java (original)
+++ james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/SMTPMessage.java Wed Sep 21 13:24:34 2011
@@ -28,18 +28,18 @@ public class SMTPMessage extends Abstrac
     private ArrayList<MessageAttachment> aList;
     
     public String toString() {
-        String bccList = "";
+        StringBuffer bccList = new StringBuffer("");
         if (bcc !=null) 
             for (String s: bcc)
-                bccList += s + " ";
+                bccList.append(s).append(" ");
         
-        String attachNames = "";
+        StringBuffer attachNames = new StringBuffer("");
         for (MessageAttachment m: aList) 
-            attachNames += m.getName() + " ";
+            attachNames.append(m.getName()).append(" ");
         
         return super.toString()
-             + " Bcc='" + bccList
-             + "'\nAttachments=" + attachNames
+             + " Bcc='" + bccList.toString()
+             + "'\nAttachments=" + attachNames.toString()
              + "'\nMessage:\n" + text;
     }
     



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org