[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9933: [multistage] add observability logging for thread scheduling

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #9933:
URL: https://github.com/apache/pinot/pull/9933#discussion_r1043681658


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChainStats.java:
##########
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.query.runtime.operator;
+
+import com.google.common.base.Stopwatch;
+import com.google.common.base.Suppliers;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+import org.apache.pinot.spi.accounting.ThreadResourceUsageProvider;
+
+
+/**
+ * {@code OpChainStats} tracks execution statistics for {@link OpChain}s.
+ */
+public class OpChainStats {
+
+  // use memoized supplier so that the timing doesn't start until the
+  // first time we get the timer
+  private final Supplier<ThreadResourceUsageProvider> _exTimer
+      = Suppliers.memoize(ThreadResourceUsageProvider::new)::get;
+
+  // this is used to make sure that toString() doesn't have side
+  // effects (accidentally starting the timer)
+  private volatile boolean _exTimerStarted = false;
+
+  private final Stopwatch _queuedStopwatch = Stopwatch.createUnstarted();
+  private final AtomicLong _queuedCount = new AtomicLong();
+
+  private final String _id;

Review Comment:
   Is this query `requestId` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org