Re: [PR] Stop @EnableWebMvc from being automatically added to Grails Applications [grails-core]

["jdaugherty (via GitHub)" <gi...@apache.org>]

jdaugherty commented on code in PR #13863:
URL: https://github.com/apache/grails-core/pull/13863#discussion_r3526438957


##########
grails-controllers/build.gradle:
##########
@@ -63,6 +63,10 @@ dependencies {
 
     testImplementation 'jakarta.servlet:jakarta.servlet-api'
     testImplementation 'org.springframework:spring-test'
+    // WebApplicationContextRunner verifies Boot's WebMvcAutoConfiguration backs off its RequestContextFilter

Review Comment:
   Remove the comments around dependenices



##########
grails-controllers/src/main/groovy/org/grails/plugins/web/controllers/ControllersAutoConfiguration.java:
##########
@@ -108,13 +108,24 @@ public FilterRegistrationBean<Filter> hiddenHttpMethodFilter() {
         return registrationBean;
     }
 
+    // Exposed as a RequestContextFilter bean (GrailsWebRequestFilter extends it) so that Boot's

Review Comment:
   Simplify the comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org