[GitHub] [cordova-plugin-media-capture] breautek commented on a change in pull request #162: (iOS) implement the 'quality' property in captureVideo()

[GitBox <gi...@apache.org>]

breautek commented on a change in pull request #162:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/162#discussion_r545390918



##########
File path: src/ios/CDVCapture.m
##########
@@ -266,7 +267,18 @@ - (void)captureVideo:(CDVInvokedUrlCommand*)command
         // iOS 4.0
         if ([pickerController respondsToSelector:@selector(cameraCaptureMode)]) {
             pickerController.cameraCaptureMode = UIImagePickerControllerCameraCaptureModeVideo;
-            // pickerController.videoQuality = UIImagePickerControllerQualityTypeHigh;
+            switch((int)([quality doubleValue]*10)) {
+                case 0: 
+                    pickerController.videoQuality = UIImagePickerControllerQualityTypeLow;
+                    break;
+                case 10: 
+                    pickerController.videoQuality = UIImagePickerControllerQualityTypeHigh;
+                    break;
+                default:
+                    pickerController.videoQuality = UIImagePickerControllerQualityTypeMedium;

Review comment:
       > Is the CI broken?
   
   Yes. Paramedic uses some third-party remote testing tools which has stopped working. One of our PMC members is trying to find a resolution, but a solution has eluded us so far.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org