You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/03/27 04:01:28 UTC

Review Request 57942: Issue in pig view after enabling strict mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57942/
-----------------------------------------------------------

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20576
    https://issues.apache.org/jira/browse/AMBARI-20576


Repository: ambari


Description
-------

Fixed vairable undefined errors after enabling strict mode


Diffs
-----

  contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 66e1c88 


Diff: https://reviews.apache.org/r/57942/diff/1/


Testing
-------

Manual tetsing done


Thanks,

venkat sairam


Re: Review Request 57942: Issue in pig view after enabling strict mode

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57942/#review170137
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 27, 2017, 4:01 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57942/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 4:01 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20576
>     https://issues.apache.org/jira/browse/AMBARI-20576
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed vairable undefined errors after enabling strict mode
> 
> 
> Diffs
> -----
> 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 66e1c88 
> 
> 
> Diff: https://reviews.apache.org/r/57942/diff/1/
> 
> 
> Testing
> -------
> 
> Manual tetsing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 57942: Issue in pig view after enabling strict mode

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57942/#review170138
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On March 27, 2017, 4:01 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57942/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 4:01 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20576
>     https://issues.apache.org/jira/browse/AMBARI-20576
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed vairable undefined errors after enabling strict mode
> 
> 
> Diffs
> -----
> 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 66e1c88 
> 
> 
> Diff: https://reviews.apache.org/r/57942/diff/1/
> 
> 
> Testing
> -------
> 
> Manual tetsing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 57942: Issue in pig view after enabling strict mode

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57942/#review170135
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On March 27, 2017, 4:01 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57942/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 4:01 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20576
>     https://issues.apache.org/jira/browse/AMBARI-20576
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed vairable undefined errors after enabling strict mode
> 
> 
> Diffs
> -----
> 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 66e1c88 
> 
> 
> Diff: https://reviews.apache.org/r/57942/diff/1/
> 
> 
> Testing
> -------
> 
> Manual tetsing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>