You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2026/07/11 12:35:41 UTC
[PR] fix: validate legal files in packaged jars [pekko]
He-Pin opened a new pull request, #3328:
URL: https://github.com/apache/pekko/pull/3328
### Motivation
Published jars can silently omit required `META-INF/LICENSE` and `META-INF/NOTICE` files. The `protobuf-v3` assembly also needs explicit merge handling for legal resources.
### Modification
- Merge LICENSE and NOTICE resources in the `protobuf-v3` assembly while retaining the protobuf COPYING file.
- Add a package validation task that checks both `packageBin` and the published artifact for required META-INF legal files.
- Include the validation task in pull request validation for published projects.
### Result
Normal package jars and assembly-backed published jars fail validation when either required legal file is missing.
### Tests
- `sbt "actor / Compile / checkPackageBinMetaInfLegalFiles" "protobuf-v3 / Compile / checkPackageBinMetaInfLegalFiles"` (pass)
- `sbt headerCreateAll "+headerCheckAll" scalafmtCheckAll scalafmtSbtCheck` (pass)
- `scalafmt --list --mode diff-ref=origin/main` (pass)
- `git diff --check` (pass)
- Qoder stdout review: no must-fix findings
- `sbt validatePullRequest` not run per request
### References
Fixes #1470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] fix: validate legal files in packaged jars [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #3328:
URL: https://github.com/apache/pekko/pull/3328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org