You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/09/26 14:05:07 UTC
[jira] [Created] (LUCENE-4435) rethink
TestCheckIndex.testLuceneConstantVersion
Robert Muir created LUCENE-4435:
-----------------------------------
Summary: rethink TestCheckIndex.testLuceneConstantVersion
Key: LUCENE-4435
URL: https://issues.apache.org/jira/browse/LUCENE-4435
Project: Lucene - Core
Issue Type: Bug
Components: general/test
Reporter: Robert Muir
This test currently checks the "display version" of lucene which is set by the ant build.xml variable.
But its been problematic in the past: and I'm sure its annoying for people running from things like IDEs.
I think LUCENE-4428 is a more straightforward way of checking that the version is set correctly, it verifies the actual JAR metadata.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4435) rethink
TestCheckIndex.testLuceneConstantVersion
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463768#comment-13463768 ]
Robert Muir commented on LUCENE-4435:
-------------------------------------
{quote}
against a hard-wired official
version (o.a.l.util.Constants.LUCENE_MAIN_VERSION).
{quote}
This is the REALLY important one we should actually be testing!
I would prefer that instead: in TestBackwardsCompatibility we add a test that reads this version from the old index,
then makes a current index and uses the comparator to ensure that the new one is greater than the old index.
This will ensure nobody forgets to bump LUCENE_MAIN_VERSION, which is important because it allows us to determine
which version of lucene wrote the segment.
> rethink TestCheckIndex.testLuceneConstantVersion
> ------------------------------------------------
>
> Key: LUCENE-4435
> URL: https://issues.apache.org/jira/browse/LUCENE-4435
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
>
> This test currently checks the "display version" of lucene which is set by the ant build.xml variable.
> But its been problematic in the past: and I'm sure its annoying for people running from things like IDEs.
> I think LUCENE-4428 is a more straightforward way of checking that the version is set correctly, it verifies the actual JAR metadata.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4435) rethink
TestCheckIndex.testLuceneConstantVersion
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463804#comment-13463804 ]
Robert Muir commented on LUCENE-4435:
-------------------------------------
For now I committed a new test for LUCENE_MAIN_VERSION (testOldVersions) since its just new coverage.
> rethink TestCheckIndex.testLuceneConstantVersion
> ------------------------------------------------
>
> Key: LUCENE-4435
> URL: https://issues.apache.org/jira/browse/LUCENE-4435
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
>
> This test currently checks the "display version" of lucene which is set by the ant build.xml variable.
> But its been problematic in the past: and I'm sure its annoying for people running from things like IDEs.
> I think LUCENE-4428 is a more straightforward way of checking that the version is set correctly, it verifies the actual JAR metadata.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4435) rethink
TestCheckIndex.testLuceneConstantVersion
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463767#comment-13463767 ]
Steven Rowe commented on LUCENE-4435:
-------------------------------------
bq. with LUCENE-4428, smoketester does all of this. I think we should just remove this test.
+1
> rethink TestCheckIndex.testLuceneConstantVersion
> ------------------------------------------------
>
> Key: LUCENE-4435
> URL: https://issues.apache.org/jira/browse/LUCENE-4435
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
>
> This test currently checks the "display version" of lucene which is set by the ant build.xml variable.
> But its been problematic in the past: and I'm sure its annoying for people running from things like IDEs.
> I think LUCENE-4428 is a more straightforward way of checking that the version is set correctly, it verifies the actual JAR metadata.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4435) rethink
TestCheckIndex.testLuceneConstantVersion
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463766#comment-13463766 ]
Robert Muir commented on LUCENE-4435:
-------------------------------------
Yeah, the test isnt a real round-trip. it only checks that a sysprop is set correctly.
But that doesnt check that the build process actually encodes this correctly into the jar (or bounce it against the expected version/changes.txt/etc).
with LUCENE-4428, smoketester does all of this. I think we should just remove this test.
> rethink TestCheckIndex.testLuceneConstantVersion
> ------------------------------------------------
>
> Key: LUCENE-4435
> URL: https://issues.apache.org/jira/browse/LUCENE-4435
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
>
> This test currently checks the "display version" of lucene which is set by the ant build.xml variable.
> But its been problematic in the past: and I'm sure its annoying for people running from things like IDEs.
> I think LUCENE-4428 is a more straightforward way of checking that the version is set correctly, it verifies the actual JAR metadata.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4435) rethink
TestCheckIndex.testLuceneConstantVersion
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463765#comment-13463765 ]
Steven Rowe commented on LUCENE-4435:
-------------------------------------
Yeah, I have a note in {{dev-tools/maven/README.maven}}:
{quote}
Note: if you change the version in the POMs, there is one test method
that will fail under maven-surefire-plugin:
o.a.l.index.TestCheckIndex#testLuceneConstantVersion(). It's safe to
@Ignore this test method, since it's just comparing the value of the
lucene.version system property (set in the maven-surefire-plugin
configuration in the lucene-core POM) against a hard-wired official
version (o.a.l.util.Constants.LUCENE_MAIN_VERSION).
{quote}
> rethink TestCheckIndex.testLuceneConstantVersion
> ------------------------------------------------
>
> Key: LUCENE-4435
> URL: https://issues.apache.org/jira/browse/LUCENE-4435
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
>
> This test currently checks the "display version" of lucene which is set by the ant build.xml variable.
> But its been problematic in the past: and I'm sure its annoying for people running from things like IDEs.
> I think LUCENE-4428 is a more straightforward way of checking that the version is set correctly, it verifies the actual JAR metadata.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org