You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/06/06 11:28:05 UTC
Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Kishan Kavala.
Bugs: CLOUDSTACK-6793
https://issues.apache.org/jira/browse/CLOUDSTACK-6793
Repository: cloudstack-git
Description
-------
1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
3. Now, creation of tags is getting successful post the fix.
Diffs
-----
engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
Diff: https://reviews.apache.org/r/19874/diff/
Testing
-------
Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
ok
Thanks,
Santhosh Edukulla
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by daan Hoogland <da...@gmail.com>.
> On June 6, 2014, 12:09 p.m., daan Hoogland wrote:
> > patch looks alright but it seems to me you have reused a review board entry for a second patch. please don't do that. close this one and start a new one next time.
>
> Santhosh Edukulla wrote:
> Sure, but reviewboard some times in process throws 5xx error and a given review request goes in to draft state. Shall i apply a new patch or this patch be considered for current one? Going ahead, i will take care to apply with a new one.
I have applied locally and am running a vlidation build. will push when passes.
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44886
-----------------------------------------------------------
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On June 6, 2014, 12:09 p.m., daan Hoogland wrote:
> > patch looks alright but it seems to me you have reused a review board entry for a second patch. please don't do that. close this one and start a new one next time.
Sure, but reviewboard some times in process throws 5xx error and a given review request goes in to draft state. Shall i apply a new patch or this patch be considered for current one? Going ahead, i will take care to apply with a new one.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44886
-----------------------------------------------------------
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44886
-----------------------------------------------------------
patch looks alright but it seems to me you have reused a review board entry for a second patch. please don't do that. close this one and start a new one next time.
- daan Hoogland
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain
Id Issue
Posted by Daan Hoogland <da...@gmail.com>.
code freeze does not mean that the schema can't be changed for bug
fixes. Any bug fix can go in if it genuinely serves the purpose of
fixing a bug.
On Fri, Jun 6, 2014 at 4:02 PM, Santhosh Edukulla
<sa...@citrix.com> wrote:
> Hi Daan,
>
> Yes, for master planning additional approach with few more enhancements, useful for future release. It may require modifying schema, which i believe is not possible for 4.4 because of code freeze.
>
> Regards
> Santhosh
> ________________________________________
> From: Daan Hoogland [daan.hoogland@gmail.com]
> Sent: Friday, June 06, 2014 9:58 AM
> To: Santhosh Edukulla
> Cc: Kishan Kavala; cloudstack
> Subject: Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
>
> Santhosh,
>
> Have you made sure this goes into master as well?
>
>
> On Fri, Jun 6, 2014 at 3:53 PM, ASF Subversion and Git Services <as...@urd.zones.apache.org>> wrote:
> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19874/
>
>
> Commit 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc in cloudstack's branch refs/heads/4.4-forward from sedukull
> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91d054c ]
>
> CLOUDSTACK-6793: Fixed an invalid Domain Id Issue
>
> Signed-off-by: sedukull <sa...@gmail.com>>
>
>
>
> - ASF Subversion and Git Services
>
>
> On June 6th, 2014, 9:28 a.m. UTC, Santhosh Edukulla wrote:
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
> By Santhosh Edukulla.
>
> Updated June 6, 2014, 9:28 a.m.
>
> Bugs: CLOUDSTACK-6793<https://issues.apache.org/jira/browse/CLOUDSTACK-6793>
> Repository: cloudstack-git
> Description
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Testing
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
>
> Diffs
>
> * engine/schema/src/com/cloud/user/dao/AccountDao.java (2f737cd)
> * engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java (4bc23ed)
> * server/src/com/cloud/tags/TaggedResourceManagerImpl.java (fa7fcb7)
>
> View Diff<https://reviews.apache.org/r/19874/diff/>
>
>
>
>
> --
> Daan
--
Daan
RE: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain
Id Issue
Posted by Santhosh Edukulla <sa...@citrix.com>.
Hi Daan,
Yes, for master planning additional approach with few more enhancements, useful for future release. It may require modifying schema, which i believe is not possible for 4.4 because of code freeze.
Regards
Santhosh
________________________________________
From: Daan Hoogland [daan.hoogland@gmail.com]
Sent: Friday, June 06, 2014 9:58 AM
To: Santhosh Edukulla
Cc: Kishan Kavala; cloudstack
Subject: Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Santhosh,
Have you made sure this goes into master as well?
On Fri, Jun 6, 2014 at 3:53 PM, ASF Subversion and Git Services <as...@urd.zones.apache.org>> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19874/
Commit 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc in cloudstack's branch refs/heads/4.4-forward from sedukull
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91d054c ]
CLOUDSTACK-6793: Fixed an invalid Domain Id Issue
Signed-off-by: sedukull <sa...@gmail.com>>
- ASF Subversion and Git Services
On June 6th, 2014, 9:28 a.m. UTC, Santhosh Edukulla wrote:
Review request for cloudstack, daan Hoogland and Kishan Kavala.
By Santhosh Edukulla.
Updated June 6, 2014, 9:28 a.m.
Bugs: CLOUDSTACK-6793<https://issues.apache.org/jira/browse/CLOUDSTACK-6793>
Repository: cloudstack-git
Description
1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
3. Now, creation of tags is getting successful post the fix.
Testing
Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
ok
Diffs
* engine/schema/src/com/cloud/user/dao/AccountDao.java (2f737cd)
* engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java (4bc23ed)
* server/src/com/cloud/tags/TaggedResourceManagerImpl.java (fa7fcb7)
View Diff<https://reviews.apache.org/r/19874/diff/>
--
Daan
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain
Id Issue
Posted by Daan Hoogland <da...@gmail.com>.
Santhosh,
Have you made sure this goes into master as well?
On Fri, Jun 6, 2014 at 3:53 PM, ASF Subversion and Git Services <
asfbot@urd.zones.apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
>
> Commit 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc in cloudstack's branch refs/heads/4.4-forward from sedukull
> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91d054c ]
>
> CLOUDSTACK-6793: Fixed an invalid Domain Id Issue
>
> Signed-off-by: sedukull <sa...@gmail.com>
>
>
> - ASF Subversion and Git Services
>
> On June 6th, 2014, 9:28 a.m. UTC, Santhosh Edukulla wrote:
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
> By Santhosh Edukulla.
>
> *Updated June 6, 2014, 9:28 a.m.*
> *Bugs: * CLOUDSTACK-6793
> <https://issues.apache.org/jira/browse/CLOUDSTACK-6793>
> *Repository: * cloudstack-git
> Description
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
> Testing
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
> Diffs
>
> - engine/schema/src/com/cloud/user/dao/AccountDao.java (2f737cd)
> - engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java (4bc23ed)
> - server/src/com/cloud/tags/TaggedResourceManagerImpl.java (fa7fcb7)
>
> View Diff <https://reviews.apache.org/r/19874/diff/>
>
--
Daan
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44889
-----------------------------------------------------------
Commit 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc in cloudstack's branch refs/heads/4.4-forward from sedukull
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91d054c ]
CLOUDSTACK-6793: Fixed an invalid Domain Id Issue
Signed-off-by: sedukull <sa...@gmail.com>
- ASF Subversion and Git Services
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44885
-----------------------------------------------------------
Ship it!
Ship It!
- Kishan Kavala
On June 6, 2014, 2:58 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 2:58 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44890
-----------------------------------------------------------
Commit 6c0b43431f7f117c1fcb049c483407b96b56d961 in cloudstack's branch refs/heads/4.4 from sedukull
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6c0b434 ]
CLOUDSTACK-6793: Fixed an invalid Domain Id Issue
Signed-off-by: sedukull <sa...@gmail.com>
(cherry picked from commit 91d054cb00f6a5818f2be1c7e4d3f44a2c58bfcc)
- ASF Subversion and Git Services
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by Rajani Karuturi <ra...@gmail.com>.
> On June 6, 2014, 6:24 p.m., Nitin Mehta wrote:
> > Hi Santosh - We should add the domain id column in the vm_template table. IMHO this is not the right fix but will mask problems where domain id is coming out -1. We need to see why domainid is coming out as -1 and solve it in the right way rather than masking it.
>
> Rajani Karuturi wrote:
> This is just a point fix for the 4.4 release to avoid schema/major changes at this point of the release.
> Also the right fix is to not add another column as we already have that info from account id. PartOf interface needs to be fixed to use the available information.
I see that santhosh already responded on the jira page https://issues.apache.org/jira/browse/CLOUDSTACK-6793?focusedCommentId=14020258
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44945
-----------------------------------------------------------
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by Rajani Karuturi <ra...@gmail.com>.
> On June 6, 2014, 6:24 p.m., Nitin Mehta wrote:
> > Hi Santosh - We should add the domain id column in the vm_template table. IMHO this is not the right fix but will mask problems where domain id is coming out -1. We need to see why domainid is coming out as -1 and solve it in the right way rather than masking it.
This is just a point fix for the 4.4 release to avoid schema/major changes at this point of the release.
Also the right fix is to not add another column as we already have that info from account id. PartOf interface needs to be fixed to use the available information.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44945
-----------------------------------------------------------
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44945
-----------------------------------------------------------
Ship it!
Hi Santosh - We should add the domain id column in the vm_template table. IMHO this is not the right fix but will mask problems where domain id is coming out -1. We need to see why domainid is coming out as -1 and solve it in the right way rather than masking it.
- Nitin Mehta
On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-6793
> https://issues.apache.org/jira/browse/CLOUDSTACK-6793
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd
> engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7
>
> Diff: https://reviews.apache.org/r/19874/diff/
>
>
> Testing
> -------
>
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
> ok
>
>
> Thanks,
>
> Santhosh Edukulla
>
>