You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/11 00:39:06 UTC

[GitHub] [superset] etr2460 commented on pull request #17654: fix: extract tables doesn't work with reserved keywords

etr2460 commented on pull request #17654:
URL: https://github.com/apache/superset/pull/17654#issuecomment-1009487562


   @betodealmeida it looks like this PR broke parsing table names from queries with sub selects. Here's a repro case:
   ```sql
   SELECT *
      FROM
        (SELECT 1 as foo, 2 as bar)
      ORDER BY foo ASC, bar
   ```
   
   ParsedQuery now thinks that `ORDER BY` and `bar` are tables:
   ![Screen Shot 2022-01-10 at 4 36 36 PM](https://user-images.githubusercontent.com/7409244/148861079-a086fa6a-5198-4f99-910b-3ce77948d195.png)
   
   Do you think this is something you could easily fix, or should we consider reverting this PR? I could possibly look into fixing myself, but the sql parse codebase is something i'm a bit nervous about jumping into
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org