You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "anoopj (via GitHub)" <gi...@apache.org> on 2026/10/21 01:11:12 UTC
[PR] Core: Implement v4 file-level tight_stats [iceberg]
anoopj opened a new pull request, #18598:
URL: https://github.com/apache/iceberg/pull/18598
Implements the file-level tight_stats flag on v4 tracked files and the related content stats changes.
Spec PR: https://github.com/apache/iceberg/pull/18585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Implement v4 file-level tight_stats [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4345212029
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -99,6 +99,13 @@ default String location() {
/** Returns if collected, map from column ID to value upper bounds, null otherwise. */
Map<Integer, ByteBuffer> upperBounds();
+ /**
+ * Returns whether the file's stats are tight, or null if unknown.
+ */
+ default Boolean tightStats() {
Review Comment:
what's the reason for adding v4-specific things to v1-v3 APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Implement v4 file-level tight_stats [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4345204790
##########
core/src/main/java/org/apache/iceberg/FieldStats.java:
##########
@@ -38,10 +38,15 @@ public interface FieldStats<T> {
T upperBound();
/**
- * Whether {@link #lowerBound()} and {@link #upperBound()} are equal to the min and max values for
- * the column.
+ * Returns whether the bounds are known to be exact.
+ *
+ * @deprecated since 1.13.0, will be removed in 2.0.0; use {@link ContentFile#tightStats()}
Review Comment:
in core we can remove directly in the next minor version after the deprecation, so this should say "...removed in 1.14.0"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Implement v4 file-level tight_stats [iceberg]
Posted by "anoopj (via GitHub)" <gi...@apache.org>.
anoopj commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4351041885
##########
core/src/main/java/org/apache/iceberg/FieldStats.java:
##########
@@ -38,10 +38,15 @@ public interface FieldStats<T> {
T upperBound();
/**
- * Whether {@link #lowerBound()} and {@link #upperBound()} are equal to the min and max values for
- * the column.
+ * Returns whether the bounds are known to be exact.
+ *
+ * @deprecated since 1.13.0, will be removed in 2.0.0; use {@link ContentFile#tightStats()}
Review Comment:
Will fix it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core: Implement v4 file-level tight_stats [iceberg]
Posted by "anoopj (via GitHub)" <gi...@apache.org>.
anoopj commented on code in PR #18598:
URL: https://github.com/apache/iceberg/pull/18598#discussion_r4351024612
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -99,6 +99,13 @@ default String location() {
/** Returns if collected, map from column ID to value upper bounds, null otherwise. */
Map<Integer, ByteBuffer> upperBounds();
+ /**
+ * Returns whether the file's stats are tight, or null if unknown.
+ */
+ default Boolean tightStats() {
Review Comment:
`ContentFile` is still the engine-facing API in v4 as well, since `TrackedFile` family is internal. So don't we need a way to expose this during reads and writes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org