You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/09/06 16:02:24 UTC
[GitHub] [geode] albertogpz opened a new pull request, #7845: GEODE-10417: Fix NullPointerException in WAN replication
albertogpz opened a new pull request, #7845:
URL: https://github.com/apache/geode/pull/7845
When the WAN group-transa$ction-events feature is enabled in
a parallel gateway sender, it is possible to get a NullPointerException
when retrieving events from the queue to complete a transaction if
the event in the queue is null.
If this situation is reached then the gateway sender dispatcher will
not dispatch queue events anymore and therefore the WAN replication
will not progress.
This happens because the predicates that check if elements
in the queue contain a transactionId are not protected
against the event being null.
A null check has been added before the predicates are invoked
so that in case of a null event, the predicate is not invoked
and the event is skipped from the checking.
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7845: GEODE-10417: Fix NullPointerException in WAN replication
Posted by GitBox <gi...@apache.org>.
albertogpz merged PR #7845:
URL: https://github.com/apache/geode/pull/7845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7845: GEODE-10417: Fix NullPointerException in WAN replication
Posted by GitBox <gi...@apache.org>.
mivanac commented on code in PR #7845:
URL: https://github.com/apache/geode/pull/7845#discussion_r964521537
##########
geode-core/src/test/java/org/apache/geode/internal/cache/BucketRegionQueueJUnitTest.java:
##########
@@ -191,6 +191,49 @@ public void testGetElementsMatchingWithParallelGatewaySenderQueuePredicatesAndSo
assertEquals(objects, Arrays.asList(event2, event4));
}
+ @Test
+ public void testGetElementsMatchingWithParallelGatewaySenderQueuePredicatesObjectReadNullDoesNotThrowException()
+ throws ForceReattemptException {
+ ParallelGatewaySenderHelper.createParallelGatewaySenderEventProcessor(this.sender);
+
+ TransactionId tx1 = new TXId(null, 1);
+ TransactionId tx2 = new TXId(null, 2);
+ TransactionId tx3 = new TXId(null, 3);
+
+ GatewaySenderEventImpl event1 = createMockGatewaySenderEvent(1, tx1, false);
+ GatewaySenderEventImpl eventNotInTransaction1 = createMockGatewaySenderEvent(2, null, false);
+ GatewaySenderEventImpl event2 = createMockGatewaySenderEvent(3, tx2, false);
+ GatewaySenderEventImpl event3 = null; // createMockGatewaySenderEvent(4, tx1, true);
+ GatewaySenderEventImpl event4 = createMockGatewaySenderEvent(5, tx2, true);
+ GatewaySenderEventImpl event5 = createMockGatewaySenderEvent(6, tx3, false);
+ GatewaySenderEventImpl event6 = createMockGatewaySenderEvent(7, tx3, false);
+ GatewaySenderEventImpl event7 = createMockGatewaySenderEvent(8, tx1, true);
+
+ this.bucketRegionQueue
+ .cleanUpDestroyedTokensAndMarkGIIComplete(InitialImageOperation.GIIStatus.NO_GII);
+
+ this.bucketRegionQueue.addToQueue(1L, event1);
+ this.bucketRegionQueue.addToQueue(2L, eventNotInTransaction1);
+ this.bucketRegionQueue.addToQueue(3L, event2);
+ this.bucketRegionQueue.addToQueue(4L, event3);
+ this.bucketRegionQueue.addToQueue(5L, event4);
+ this.bucketRegionQueue.addToQueue(6L, event5);
+ this.bucketRegionQueue.addToQueue(7L, event6);
+ this.bucketRegionQueue.addToQueue(8L, event7);
+
+ Predicate<GatewaySenderEventImpl> hasTransactionIdPredicate =
+ ParallelGatewaySenderQueue.getHasTransactionIdPredicate(tx1);
+ Predicate<GatewaySenderEventImpl> isLastEventInTransactionPredicate =
+ ParallelGatewaySenderQueue.getIsLastEventInTransactionPredicate();
+ when(bucketRegionQueue.getValueInVMOrDiskWithoutFaultIn(4L)).thenReturn(null);
+ List<Object> objects = this.bucketRegionQueue.getElementsMatching(hasTransactionIdPredicate,
+ isLastEventInTransactionPredicate);
+
+ assertEquals(2, objects.size());
+ assertEquals(objects, Arrays.asList(new Object[] {event1, event7}));
Review Comment:
Please replace all with AssertJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jvarenina commented on pull request #7845: GEODE-10417: Fix NullPointerException in WAN replication
Posted by GitBox <gi...@apache.org>.
jvarenina commented on PR #7845:
URL: https://github.com/apache/geode/pull/7845#issuecomment-1239043813
No comments from my side. Good work Alberto!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org