You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/01 18:34:02 UTC

[GitHub] [couchdb] sdahlbac opened a new pull request #3188: vm.args: add note about changing -name

sdahlbac opened a new pull request #3188:
URL: https://github.com/apache/couchdb/pull/3188


   Try to gently suggest using option #2
   
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   As per discussions in slack a few days ago:
   
   Since changing -name after the fact involves moving all the shards, which is a bit of work and potentially errorprone.
   
   Try to nudge user towards not using the couchdb@127.0.0.1 if there is a possibility that e.g. clustering is needed down the road.
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   N/A
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] sdahlbac commented on pull request #3188: vm.args: add note about changing -name

Posted by GitBox <gi...@apache.org>.
sdahlbac commented on pull request #3188:
URL: https://github.com/apache/couchdb/pull/3188#issuecomment-703733555


   Sure, I'll do that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] wohali commented on pull request #3188: vm.args: add note about changing -name

Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3188:
URL: https://github.com/apache/couchdb/pull/3188#issuecomment-703732413


   As this is a footnote and only applies to people changing the value after the fact, It would be preferable to put this in the documentation, not in this file.
   
   Would you consider opening a pull request against our documentation repository instead?  https://github.com/apache/couchdb-documentation/ Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] wohali closed pull request #3188: vm.args: add note about changing -name

Posted by GitBox <gi...@apache.org>.
wohali closed pull request #3188:
URL: https://github.com/apache/couchdb/pull/3188


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org