You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/10 08:25:04 UTC
[jira] [Commented] (ROCKETMQ-138) Add AuthenticationException class
to remove hard coded Aliyun authentication class
[ https://issues.apache.org/jira/browse/ROCKETMQ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904696#comment-15904696 ]
ASF GitHub Bot commented on ROCKETMQ-138:
-----------------------------------------
GitHub user Jaskey opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/75
Add AuthenticationException class to remove hard coded Aliyun authentication code
JIRA:https://issues.apache.org/jira/browse/ROCKETMQ-138
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jaskey/incubator-rocketmq ROCKETMQ-138-AuthenticationException
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 79bb95e5fa7c8ddbf224e22868b13451b7c21f8b
Author: Jaskey <li...@gmail.com>
Date: 2017-03-10T08:17:05Z
Add AuthenticationException class to remove hard coded Aliyun authentication class
----
> Add AuthenticationException class to remove hard coded Aliyun authentication class
> ----------------------------------------------------------------------------------
>
> Key: ROCKETMQ-138
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-138
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-remoting
> Reporter: Jaskey Lam
> Assignee: vongosling
>
> in NettyRemotingAbstract.java
> a hard coded aliyun class is used
> {code}
> catch (Throwable e) {
> if (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"
> .equals(e.getClass().getCanonicalName())) {
> PLOG.error("process request exception", e);
> PLOG.error(cmd.toString());
> }
> {code}
> A common AuthenticationException should be added to identify Authentication failure. Developers can throw this exception so that remoting component can ignore it
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)