[GitHub] [druid] jihoonson commented on a change in pull request #12194: fix StringAnyAggregatorFactory to use single value selector for non-existent columns

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #12194:
URL: https://github.com/apache/druid/pull/12194#discussion_r791162190



##########
File path: processing/src/main/java/org/apache/druid/segment/ColumnProcessors.java
##########
@@ -342,7 +342,7 @@ private static ColumnCapabilities computeDimensionSpecCapabilities(
           );
         }
 
-        if (mayBeMultiValue(capabilities)) {
+        if (capabilities.hasMultipleValues().isMaybeTrue()) {

Review comment:
       nit: perhaps it would be useful to add a util method like `shouldProcessMultiValue()` that can be shared by here and `StringAnyAggregatorFactory`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org