You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2016/03/14 22:43:16 UTC
[07/13] wicket git commit: Do not log the RequestCycle. It doesn't
provide useful #toString() anyway.
Do not log the RequestCycle. It doesn't provide useful #toString() anyway.
It just made useless ThreadLocal lookup until now
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d1ecda8d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d1ecda8d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d1ecda8d
Branch: refs/heads/master
Commit: d1ecda8d42a3534503d575085f6b7e8e2b273dde
Parents: 9e3aca6
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Mar 14 21:01:31 2016 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Mar 14 22:42:55 2016 +0100
----------------------------------------------------------------------
.../java/org/apache/wicket/model/LoadableDetachableModel.java | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/d1ecda8d/wicket-core/src/main/java/org/apache/wicket/model/LoadableDetachableModel.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/model/LoadableDetachableModel.java b/wicket-core/src/main/java/org/apache/wicket/model/LoadableDetachableModel.java
index 615d595..8836cfc 100644
--- a/wicket-core/src/main/java/org/apache/wicket/model/LoadableDetachableModel.java
+++ b/wicket-core/src/main/java/org/apache/wicket/model/LoadableDetachableModel.java
@@ -16,7 +16,6 @@
*/
package org.apache.wicket.model;
-import org.apache.wicket.request.cycle.RequestCycle;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -109,8 +108,7 @@ public abstract class LoadableDetachableModel<T> implements IModel<T>
state = InternalState.DETACHED;
transientModelObject = null;
- log.debug("removed transient object for {}, requestCycle {}", this,
- RequestCycle.get());
+ log.debug("removed transient object for '{}'", this);
}
}
}
@@ -127,8 +125,7 @@ public abstract class LoadableDetachableModel<T> implements IModel<T>
if (log.isDebugEnabled())
{
- log.debug("loaded transient object " + transientModelObject + " for " + this +
- ", requestCycle " + RequestCycle.get());
+ log.debug("loaded transient object '{}' for '{}'", transientModelObject, this);
}
state = InternalState.ATTACHED;