[GitHub] [ozone] JacksonYao287 commented on a diff in pull request #3453: HDDS-6795: EC: PipelineStateMap#addPipeline should not have precondition checks post db updates

[GitBox <gi...@apache.org>]

JacksonYao287 commented on code in PR #3453:
URL: https://github.com/apache/ozone/pull/3453#discussion_r882384077


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java:
##########
@@ -194,6 +194,18 @@ public Pipeline createPipeline(ReplicationConfig replicationConfig,
     try {
       Pipeline pipeline = pipelineFactory.create(replicationConfig,
           excludedNodes, favoredNodes);
+      // In case in case if provided pipeline provider returns null.

Review Comment:
   agree with stephen. maybe we would better to check and handle this in that certain placement policy. if the placement policy can not choose enough datanodes for the new pipeline , an exception should be thrown from it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org