You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2024/11/01 04:50:49 UTC

Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]

amoghrajesh commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1825425230


##########
providers/src/airflow/providers/cncf/kubernetes/decorators/kubernetes.py:
##########
@@ -65,7 +65,7 @@ class _KubernetesDecoratedOperator(DecoratedOperator, KubernetesPodOperator):
     # there are some cases we can't deepcopy the objects (e.g protobuf).
     shallow_copy_attrs: Sequence[str] = ("python_callable",)
 
-    def __init__(self, namespace: str = "default", use_dill: bool = False, **kwargs) -> None:
+    def __init__(self, namespace: str | None = None, use_dill: bool = False, **kwargs) -> None:

Review Comment:
   Looks like a breaking change to me, it will affect users who do not initialise the decorator namespace right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org