[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1605: [CELEBORN-695]Fix UnsupportedOperationException by refactoring WorkerInfo

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1605:
URL: https://github.com/apache/incubator-celeborn/pull/1605#discussion_r1233871244


##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -249,9 +249,11 @@ private[celeborn] class Master(
       val pushPort = pbRegisterWorker.getPushPort
       val fetchPort = pbRegisterWorker.getFetchPort
       val replicatePort = pbRegisterWorker.getReplicatePort
-      val disks = pbRegisterWorker.getDisksList.asScala
-        .map { pbDiskInfo => pbDiskInfo.getMountPoint -> PbSerDeUtils.fromPbDiskInfo(pbDiskInfo) }
-        .toMap.asJava
+      val disks = new util.HashMap[String, DiskInfo]()

Review Comment:
   Reverted, though I prefer to change because it avoids some conversions between java and scala. But it's trivial, both are fine to me :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org