[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet

[GitBox <gi...@apache.org>]

terrymanu commented on issue #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet
URL: https://github.com/apache/incubator-shardingsphere/pull/4952#issuecomment-604513580
 
 
   > > Please inline the return value
   > 
   > @terrymanu
   > Did you say **inline the return value** like this:
   > 
   > ```
   >     @Override
   >     public boolean isFirst() throws SQLException {
   >         boolean first = originalResultSet.isFirst();
   >         return first;
   >     }
   > ```
   > 
   > change to ->
   > 
   > ```
   >     @Override
   >     public boolean isFirst() throws SQLException {
   >         return originalResultSet.isFirst();
   >     }
   > ```
   
   Yes, you catch the point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services