You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/09/08 08:00:27 UTC

[PR] fix(desktop): unblock sends after a failed local message [maka]

me2seeks opened a new pull request, #5008:
URL: https://github.com/apache/maka/pull/5008

   ## Summary
   
   Fixes #5007
   
   After a local message is definitively refused, later messages in the same Session now send without requiring the user to delete the failed copy. The failed text and removal action remain available. Unknown Host outcomes still block subsequent delivery until reconciled, preserving admission order.
   
   Skip settled failures before reserving the Session's delivery position. Regression coverage exercises both an operation refusal and a blocked Skill result, plus unknown-outcome reconciliation using the real local SQLite store.
   
   ## Verification
   
   - Before the fix: both refusal regression cases fail because subsequent messages remain local; the unknown-outcome control passes.
   - After the fix: local-message suite passes (23 tests); full Desktop `test:dist` passes (2,479 tests, zero failures/skips).
   - `npm run build`, `npm run lint`, `npm run format:check`, `npm run typecheck`: passed.
   - `npx knip --workspace apps/desktop` and `npx knip --workspace packages/ui`: passed.
   
   Behavior evidence from the regression assertions:
   
   ```text
   Before: A=failed; B and C remain saved; submit calls=[A]
   After:  A=failed and retained; B and C accepted; submit calls=[A,B,C]
   Unknown outcome: later same-Session send waits until A is reconciled
   ```
   
   No renderer layout or copy changes. The original Stop-to-first-refusal trigger is not established by this fix; the reproduction injects the initial Host refusal. Delivery wording and recovery affordances remain separate UX follow-up scope.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex investigated the reproduction, authored the patch and tests, ran validation, and prepared this PR on behalf of @me2seeks.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] fix(desktop): unblock sends after a failed local message [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #5008:
URL: https://github.com/apache/maka/pull/5008


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org