You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/17 08:47:58 UTC

[GitHub] [incubator-kvrocks] GoGim1 opened a new issue, #637: Enhancement: More user-friendly error message

GoGim1 opened a new issue, #637:
URL: https://github.com/apache/incubator-kvrocks/issues/637

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   I get two kinds of error messages when I exec kvrock2redis like this:
   * if the `data-dir` in config file is an unexist path,  it shows `Failed to load config, err: NotFound: `
   * if the config file is not found,  it shows `Failed to load config, err: No such file or directory`
   
   I think it need a more accurate error message to distinguish this two cases. 
   
   ### Solution
   
   Maybe the simpliest way to solve this problem is to append `+ data_dir` after `s.ToString()`:
   https://github.com/apache/incubator-kvrocks/blob/c391953f92fc03b4d22e100a42024a898f3fae47/tools/kvrocks2redis/config.cc#L143
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] torwig closed issue #637: Enhancement: More user-friendly error message

Posted by GitBox <gi...@apache.org>.
torwig closed issue #637: Enhancement: More user-friendly error message 
URL: https://github.com/apache/incubator-kvrocks/issues/637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #637: Enhancement: More user-friendly error message

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #637:
URL: https://github.com/apache/incubator-kvrocks/issues/637#issuecomment-1158729273

   This improvement makes sense to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org