You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "julianhyde (via GitHub)" <gi...@apache.org> on 2023/06/08 21:51:39 UTC

[GitHub] [calcite] julianhyde commented on pull request #3248: [CALCITE-5757] Correct DATE_TRUNC return type and convert DATEs to TIMESTAMPs for DATETIME_TRUNC and TIMESTAMP_TRUNC for BigQuery

julianhyde commented on PR #3248:
URL: https://github.com/apache/calcite/pull/3248#issuecomment-1583437350

   The commit message is currently as follows:
   
   > Correct DATE_TRUNC return type and convert DATEs to TIMESTAMPs for DATETIME_TRUNC and TIMESTAMP_TRUNC for BigQuery
   
   That contains 'correct', which is a synonym for 'fix', and is superfluous. Just state the desired behavior. Would the following be better?
   
   > BigQuery functions DATETIME_TRUNC and TIMESTAMP_TRUNC should return same type as their first argument, and DATE_TRUNC should return DATE


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org