You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "hqhq1025 (via GitHub)" <gi...@apache.org> on 2026/09/24 03:37:25 UTC
Re: [PR] chore(deps): bump the minor-and-patch group across 1 directory with 22 updates [maka]
hqhq1025 commented on code in PR #5651:
URL: https://github.com/apache/maka/pull/5651#discussion_r4089601889
##########
packages/runtime/package.json:
##########
@@ -153,15 +153,15 @@
"test:dist": "node --test \"dist/**/*.test.js\""
},
"dependencies": {
- "@ai-sdk/anthropic": "4.0.53",
- "@ai-sdk/code-mode": "1.0.56",
- "@ai-sdk/cohere": "4.0.41",
- "@ai-sdk/google": "4.0.69",
- "@ai-sdk/open-responses": "2.0.44",
- "@ai-sdk/openai": "4.0.66",
- "@ai-sdk/openai-compatible": "3.0.48",
- "@ai-sdk/provider": "4.0.14",
- "@larksuiteoapi/node-sdk": "1.73.3",
+ "@ai-sdk/anthropic": "4.0.58",
+ "@ai-sdk/code-mode": "1.0.64",
+ "@ai-sdk/cohere": "4.0.46",
+ "@ai-sdk/google": "4.0.76",
+ "@ai-sdk/open-responses": "2.0.49",
+ "@ai-sdk/openai": "4.0.71",
+ "@ai-sdk/openai-compatible": "3.0.53",
+ "@ai-sdk/provider": "4.0.17",
Review Comment:
[P2] The runtime now requires `@ai-sdk/provider` 4.0.17 (and `ai` 7.0.107 at line 173), but `package-lock.json` still installs nested runtime copies at 4.0.14 and 7.0.99 (lines 17277 and 17355). Both the current audit CI and local `npm ls --workspace maka-agent --omit=dev --all --json` report these as invalid/ELSPROBLEMS. Regenerate the lock tree and verify the resolved workspace dependencies.
##########
packages/runtime/package.json:
##########
@@ -153,15 +153,15 @@
"test:dist": "node --test \"dist/**/*.test.js\""
},
"dependencies": {
- "@ai-sdk/anthropic": "4.0.53",
- "@ai-sdk/code-mode": "1.0.56",
- "@ai-sdk/cohere": "4.0.41",
- "@ai-sdk/google": "4.0.69",
- "@ai-sdk/open-responses": "2.0.44",
- "@ai-sdk/openai": "4.0.66",
- "@ai-sdk/openai-compatible": "3.0.48",
- "@ai-sdk/provider": "4.0.14",
- "@larksuiteoapi/node-sdk": "1.73.3",
+ "@ai-sdk/anthropic": "4.0.58",
+ "@ai-sdk/code-mode": "1.0.64",
Review Comment:
[P1] `@ai-sdk/code-mode` 1.0.64 is hoisted to root `node_modules` in the new lockfile, while `patches/@maka+runtime++@ai-sdk+code-mode+1.0.56.patch` targets the former nested path. Root `npm ci` reports that code-mode is absent at that path and exits 1. The runtime still passes `timeoutMode: execution`, so the old patch cannot simply be assumed unnecessary; update the patch/location after checking the new upstream API.
##########
packages/cli/package.json:
##########
@@ -20,7 +20,7 @@
},
"dependencies": {
"@agentclientprotocol/sdk": "1.4.0",
- "@earendil-works/pi-tui": "0.85.1",
+ "@earendil-works/pi-tui": "0.86.1",
Review Comment:
[P1] The 0.86.1 upgrade leaves `patches/@earendil-works+pi-tui+0.85.1.patch` in place. On Node 24, root `npm ci` reports that this patch conflicts with the installed 0.86.1 package; `scripts/apply-dependency-patches.mjs` runs patch-package with `--error-on-fail`, so postinstall and the install-dependent CI lanes stop. Rebase the patch against 0.86.1, or remove it only after confirming upstream now supplies the required behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org