[GitHub] [beam] lukecwik commented on a change in pull request #12983: [BEAM-10994] Add hotKeyLoggingEnabled to the Java DataflowPipelineOptions

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #12983:
URL: https://github.com/apache/beam/pull/12983#discussion_r498335727



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
##########
@@ -197,4 +197,11 @@ public String create(PipelineOptions options) {
           .toString();
     }
   }
+
+  /** If enabled then the literal key will be logged to Cloud Logging if a hot key is detected. */
+  @Description(
+      "If enabled then the literal key will be logged to Cloud Logging if a hot key is detected.")
+  boolean getHotKeyLoggingEnabled();

Review comment:
       Note that you can use "is" for boolean types on the getter. Do whatever is the most common though in the codebase for consistency reasons.
   
   ```suggestion
     boolean isHotKeyLoggingEnabled();
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org