You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/11/08 07:54:33 UTC
Review Request 40054: Fix fetch parsing problem for URL with query.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Ben Mahler.
Bugs: MESOS-3367
https://issues.apache.org/jira/browse/MESOS-3367
Repository: mesos
Description
-------
Fix fetch parsing problem for URL with query.
Diffs
-----
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review105603
-----------------------------------------------------------
Bad patch!
Reviews applied: [40053]
Failed command: ./support/apply-review.sh -n -r 40053
Error:
2015-11-08 07:08:19 URL:https://reviews.apache.org/r/40053/diff/raw/ [3177448/3177448] -> "40053.patch" [1]
error: patch failed: 3rdparty/libprocess/include/process/http.hpp:68
error: 3rdparty/libprocess/include/process/http.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/http.cpp:31
error: 3rdparty/libprocess/src/http.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 8, 2015, 7 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2015, 7 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Bugs: MESOS-3367
> https://issues.apache.org/jira/browse/MESOS-3367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix fetch parsing problem for URL with query.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/40054/diff/
>
>
> Testing
> -------
>
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review105615
-----------------------------------------------------------
Bad patch!
Reviews applied: [40053]
Failed command: ./support/apply-review.sh -n -r 40053
Error:
2015-11-08 16:23:58 URL:https://reviews.apache.org/r/40053/diff/raw/ [3177448/3177448] -> "40053.patch" [1]
error: patch failed: 3rdparty/libprocess/include/process/http.hpp:68
error: 3rdparty/libprocess/include/process/http.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/http.cpp:31
error: 3rdparty/libprocess/src/http.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 8, 2015, 3:57 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2015, 3:57 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Bugs: MESOS-3367
> https://issues.apache.org/jira/browse/MESOS-3367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix fetch parsing problem for URL with query.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/40054/diff/
>
>
> Testing
> -------
>
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by Bernd Mathiske <be...@mesosphere.io>.
> On Nov. 13, 2015, 12:17 a.m., Bernd Mathiske wrote:
> > Did you run all the fetcher tests?
Ah, I guess ReviewBot did :-)
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review106379
-----------------------------------------------------------
On Nov. 8, 2015, 7:57 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2015, 7:57 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Bugs: MESOS-3367
> https://issues.apache.org/jira/browse/MESOS-3367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix fetch parsing problem for URL with query.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/40054/diff/
>
>
> Testing
> -------
>
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review106379
-----------------------------------------------------------
Ship it!
Did you run all the fetcher tests?
- Bernd Mathiske
On Nov. 8, 2015, 7:57 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2015, 7:57 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Bugs: MESOS-3367
> https://issues.apache.org/jira/browse/MESOS-3367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix fetch parsing problem for URL with query.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/40054/diff/
>
>
> Testing
> -------
>
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review105618
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40053, 40054]
All tests passed.
- Mesos ReviewBot
On Nov. 8, 2015, 3:57 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2015, 3:57 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Bugs: MESOS-3367
> https://issues.apache.org/jira/browse/MESOS-3367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix fetch parsing problem for URL with query.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/40054/diff/
>
>
> Testing
> -------
>
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/
-----------------------------------------------------------
(Updated Nov. 8, 2015, 3:57 p.m.)
Review request for mesos, Bernd Mathiske and Ben Mahler.
Changes
-------
Rebase
Bugs: MESOS-3367
https://issues.apache.org/jira/browse/MESOS-3367
Repository: mesos
Description
-------
Fix fetch parsing problem for URL with query.
Diffs (updated)
-----
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing
-------
# Add `FetcherTest.OSNetUriWithQueryTest` test case.
# @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
Thanks,
haosdent huang
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review105613
-----------------------------------------------------------
Bad patch!
Reviews applied: [40053]
Failed command: ./support/apply-review.sh -n -r 40053
Error:
2015-11-08 13:53:54 URL:https://reviews.apache.org/r/40053/diff/raw/ [3177448/3177448] -> "40053.patch" [1]
error: patch failed: 3rdparty/libprocess/include/process/http.hpp:68
error: 3rdparty/libprocess/include/process/http.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/http.cpp:31
error: 3rdparty/libprocess/src/http.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 8, 2015, 1:34 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2015, 1:34 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Bugs: MESOS-3367
> https://issues.apache.org/jira/browse/MESOS-3367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix fetch parsing problem for URL with query.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/40054/diff/
>
>
> Testing
> -------
>
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/
-----------------------------------------------------------
(Updated Nov. 8, 2015, 1:34 p.m.)
Review request for mesos, Bernd Mathiske and Ben Mahler.
Changes
-------
When uri not start with protocol specifier, treat it as a normal path directly.
Bugs: MESOS-3367
https://issues.apache.org/jira/browse/MESOS-3367
Repository: mesos
Description
-------
Fix fetch parsing problem for URL with query.
Diffs (updated)
-----
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing
-------
# Add `FetcherTest.OSNetUriWithQueryTest` test case.
# @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
Thanks,
haosdent huang
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/#review105604
-----------------------------------------------------------
Bad patch!
Reviews applied: [40053]
Failed command: ./support/apply-review.sh -n -r 40053
Error:
2015-11-08 07:28:10 URL:https://reviews.apache.org/r/40053/diff/raw/ [3177448/3177448] -> "40053.patch" [1]
error: patch failed: 3rdparty/libprocess/include/process/http.hpp:68
error: 3rdparty/libprocess/include/process/http.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/http.cpp:31
error: 3rdparty/libprocess/src/http.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 8, 2015, 7:18 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40054/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2015, 7:18 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Bugs: MESOS-3367
> https://issues.apache.org/jira/browse/MESOS-3367
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix fetch parsing problem for URL with query.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
>
> Diff: https://reviews.apache.org/r/40054/diff/
>
>
> Testing
> -------
>
> # Add `FetcherTest.OSNetUriWithQueryTest` test case.
> # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/
-----------------------------------------------------------
(Updated Nov. 8, 2015, 7:18 a.m.)
Review request for mesos, Bernd Mathiske and Ben Mahler.
Changes
-------
Rebase
Bugs: MESOS-3367
https://issues.apache.org/jira/browse/MESOS-3367
Repository: mesos
Description
-------
Fix fetch parsing problem for URL with query.
Diffs (updated)
-----
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing
-------
# Add `FetcherTest.OSNetUriWithQueryTest` test case.
# @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
Thanks,
haosdent huang
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/
-----------------------------------------------------------
(Updated Nov. 8, 2015, 7 a.m.)
Review request for mesos, Bernd Mathiske and Ben Mahler.
Bugs: MESOS-3367
https://issues.apache.org/jira/browse/MESOS-3367
Repository: mesos
Description
-------
Fix fetch parsing problem for URL with query.
Diffs
-----
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing (updated)
-------
# Add `FetcherTest.OSNetUriWithQueryTest` test case.
# @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing function for URL maybe better, it also could fix the TODO item. I think we also could update the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename function.
Thanks,
haosdent huang
Re: Review Request 40054: Fix fetch parsing problem for URL with
query.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/
-----------------------------------------------------------
(Updated Nov. 8, 2015, 6:57 a.m.)
Review request for mesos, Bernd Mathiske and Ben Mahler.
Bugs: MESOS-3367
https://issues.apache.org/jira/browse/MESOS-3367
Repository: mesos
Description
-------
Fix fetch parsing problem for URL with query.
Diffs
-----
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing (updated)
-------
# Add `FetcherTest.OSNetUriWithQueryTest` test case.
Thanks,
haosdent huang