You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stephen Judkins (JIRA)" <ji...@apache.org> on 2009/06/21 00:54:07 UTC

[jira] Created: (CASSANDRA-247) Thrift interface uses reserved keyword "end"

Thrift interface uses reserved keyword "end"
--------------------------------------------

                 Key: CASSANDRA-247
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-247
             Project: Cassandra
          Issue Type: Bug
            Reporter: Stephen Judkins


The definition for get_slice_by_name_range has an argument named "end".

According to https://issues.apache.org/jira/browse/THRIFT-434, this will soon become an illegal keyword in Thrift definitions due to its use as a reserved keyword in Ruby.

Currently, attempting to use the Ruby interface results in syntax errors unless the interface definition is changed prior to generation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-247) Thrift interface uses reserved keyword "end"

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723060#action_12723060 ] 

Hudson commented on CASSANDRA-247:
----------------------------------

Integrated in Cassandra #117 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/117/])
    rename "end" parameter to "finish" to avoid conflict w/ ruby keyword.  patch by Stu Hood; reviewed by jbellis for 


> Thrift interface uses reserved keyword "end"
> --------------------------------------------
>
>                 Key: CASSANDRA-247
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-247
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stephen Judkins
>            Assignee: Stephen Judkins
>         Attachments: CASSANDRA-247.patch
>
>
> The definition for get_slice_by_name_range has an argument named "end".
> According to https://issues.apache.org/jira/browse/THRIFT-434, this will soon become an illegal keyword in Thrift definitions due to its use as a reserved keyword in Ruby.
> Currently, attempting to use the Ruby interface results in syntax errors unless the interface definition is changed prior to generation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-247) Thrift interface uses reserved keyword "end"

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated CASSANDRA-247:
-------------------------------------

    Component/s: Core

> Thrift interface uses reserved keyword "end"
> --------------------------------------------
>
>                 Key: CASSANDRA-247
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-247
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Stephen Judkins
>            Assignee: Stephen Judkins
>             Fix For: 0.4
>
>         Attachments: CASSANDRA-247.patch
>
>
> The definition for get_slice_by_name_range has an argument named "end".
> According to https://issues.apache.org/jira/browse/THRIFT-434, this will soon become an illegal keyword in Thrift definitions due to its use as a reserved keyword in Ruby.
> Currently, attempting to use the Ruby interface results in syntax errors unless the interface definition is changed prior to generation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-247) Thrift interface uses reserved keyword "end"

Posted by "Stephen Judkins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Judkins updated CASSANDRA-247:
--------------------------------------

    Attachment: CASSANDRA-247.patch

This patch changes argument for get_slice_by_name_range from "end" to "finish" in interface definition.

I'm fairly certain this won't break much of anything? Correct me if I'm wrong.

> Thrift interface uses reserved keyword "end"
> --------------------------------------------
>
>                 Key: CASSANDRA-247
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-247
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stephen Judkins
>         Attachments: CASSANDRA-247.patch
>
>
> The definition for get_slice_by_name_range has an argument named "end".
> According to https://issues.apache.org/jira/browse/THRIFT-434, this will soon become an illegal keyword in Thrift definitions due to its use as a reserved keyword in Ruby.
> Currently, attempting to use the Ruby interface results in syntax errors unless the interface definition is changed prior to generation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.