[GitHub] [nifi] jfrazee commented on pull request #4460: NIFI-7717 Updated main NiFi images to JRE 11.

[GitBox <gi...@apache.org>]

jfrazee commented on pull request #4460:
URL: https://github.com/apache/nifi/pull/4460#issuecomment-779386944


   @MikeThomsen I wanted to come back to this. I've been using this for a while now and think it'd be helpful to split off the image/repository name, the image tag, and the maintainer as ARGs. For example:
   
   ```dockerfile
   ARG IMAGE_NAME=openjdk
   ARG IMAGE_TAG=8-jre
   ARG MAINTAINER="Apache NiFi <de...@nifi.apache.org>"
   
   FROM ${IMAGE_NAME}:${IMAGE_TAG} AS artifactbase
   LABEL maintainer="${MAINTAINER}"
   
   ...
   
   FROM ${IMAGE_NAME}:${IMAGE_TAG}
   LABEL maintainer="${MAINTAINER}"
   ```
   
   And:
   
   ```xml
   <properties>
       <docker.image.name>openjdk</docker.image.name>
       <docker.image.tag>8-jre</docker.image.tag>
       <docker.maintainer><![CDATA[Apache NiFi <de...@nifi.apache.org>]]></docker.maintainer>
   </properties>
   ```
   
   What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org