You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/01 14:36:09 UTC

[GitHub] NicoK opened a new pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name

NicoK opened a new pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name
URL: https://github.com/apache/flink/pull/6470
 
 
   ## What is the purpose of the change
   
   Almost all log messages of `BarrierBuffer` do not contain the task name and are therefore of little use if either multiple slots are executed on a single TM or multiple checkpoints run in parallel.
   
   Please also merge to `release-1.6` and `master`.
   
   ## Brief change log
   
   - prepend the owning task name to `BarrierBuffer` log messages (available from the `InputGate`)
   - add task name to `SingleInputGate` logs
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   - Tested manually the log messages with logging level set to `DEBUG` and the `SocketWindowWordCount` with checkpointing and parallelism 4.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services