You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2010/02/19 08:23:16 UTC
DO NOT REPLY [Bug 48771] [PATCH] CleanerThread never terminates,
causes leaks in webapp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48771
Helder Magalhães <he...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
URL| |http://mail-archives.apache
| |.org/mod_mbox/xmlgraphics-b
| |atik-users/201002.mbox/%3C2
| |7631790.post@talk.nabble.co
| |m%3E
Summary|CleanerThread never |[PATCH] CleanerThread never
|terminates, causes leaks in |terminates, causes leaks in
|webapp |webapp
--- Comment #1 from Helder Magalhães <he...@gmail.com> 2010-02-19 07:23:10 UTC ---
Thanks for taking the time to investigate/share the patch, Joel! :-)
Without testing it, I think it would be interesting to mention that there was
some discussion about this in the mailing list prior to this bug report being
created. I've added a link to in as the issue's URL. ;-)
I'm also adding metadata to reflect that a patch was made available.
Should/can this be related to bug 44178? At least, one may be interested in
reviewing both issues together... :-)
A (somehow) quick review of the patch, mostly with cosmetic nits, follows.
> + public static final CleanerThread THREAD = new CleanerThread();
Double space before "THREAD".
> + queue = new ReferenceQueue<Object>();
We're not using generics yet, as Batik still targets Java 1.4 compatibility
AFAIK (see bug 46434). Could this be reworked?
> + ReferenceQueue<Object> rq;
Tab character here. Indentation is made using 4 spaces within the framework.
> + } catch (InterruptedException e) {
> +
> + }
I'd say that either insert a comment, stating why the exception is ignored (if
it matters), or get rid of the extraneous line.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org