You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/14 13:04:31 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #42930: [SPARK-45168][PYTHON] Increate Pandas minimum version to 1.4.4
zhengruifeng opened a new pull request, #42930:
URL: https://github.com/apache/spark/pull/42930
### What changes were proposed in this pull request?
Increate Pandas minimum version to 1.4.4
### Why are the changes needed?
pandas 1.0.5 was released 3 year ago, and the latest version is 2.1.0.
[1.4.4](https://pandas.pydata.org/docs/whatsnew/v1.4.4.html#) was released at August 31, 2022, and it is the last maintenance release in 1.4.
1.4.4 should be a fine choice.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42930: [SPARK-45168][PYTHON] Increate Pandas minimum version to 1.4.4
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42930:
URL: https://github.com/apache/spark/pull/42930#issuecomment-1719417570
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42930: [SPARK-45168][PYTHON] Increase Pandas minimum version to 1.4.4
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42930:
URL: https://github.com/apache/spark/pull/42930#issuecomment-1720743852
No problem at all~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42930: [SPARK-45168][PYTHON] Increase Pandas minimum version to 1.4.4
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42930:
URL: https://github.com/apache/spark/pull/42930#issuecomment-1720695226
thanks @dongjoon-hyun and @HyukjinKwon
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42930: [SPARK-45168][PYTHON] Increase Pandas minimum version to 1.4.4
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42930:
URL: https://github.com/apache/spark/pull/42930#issuecomment-1720301980
> Could you check the PySpark test failures?
>
> In addition to the style issue,
>
> ```
> flake8 checks failed:
> ./python/pyspark/pandas/resample.py:35:1: F401 'pandas.core.common._builtin_table' imported but unused
> from pandas.core.common import _builtin_table # type: ignore[attr-defined]
> ^
> ./python/pyspark/pandas/tests/test_indexing.py:231:9: F841 local variable 'pdf' is assigned to but never used
> pdf = self.pdf.set_index("b", append=True)
> ^
> 1 F401 'pandas.core.common._builtin_table' imported but unused
> 1 F841 local variable 'pdf' is assigned to but never used
> ```
sure, let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #42930: [SPARK-45168][PYTHON] Increase Pandas minimum version to 1.4.4
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #42930: [SPARK-45168][PYTHON] Increase Pandas minimum version to 1.4.4
URL: https://github.com/apache/spark/pull/42930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #42930: [SPARK-45168][PYTHON] Increase Pandas minimum version to 1.4.4
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #42930:
URL: https://github.com/apache/spark/pull/42930#issuecomment-1720737302
oh, sorry, I find there are still some similar places to clean up, let me create a follow-up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org