You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/27 05:15:49 UTC
[I] Add unit test coverage for WorkflowExecutionService state events and teardown [texera]
aglinxinyuan opened a new issue, #8033:
URL: https://github.com/apache/texera/issues/8033
### Task Summary
`WorkflowExecutionService` sits at 26 of 72 fully-covered lines. Its spec has three tests, all of which stop at construction — the class's state-event handler and its teardown path are entirely unexercised.
Two gaps in particular:
- **`createStateEvent` / the metadata-store subscription.** The handler decides whether a `WorkflowStateEvent` is emitted at all, and reports a recovering execution as `Recovering` rather than as its aggregated state. Nothing pins either decision.
- **`unsubscribeAll`.** The teardown shuts the client down and unsubscribes four services. No test reaches it, so a dropped `unsubscribeAll` call would go unnoticed.
The companion's `getLatestExecutionID` also has no test in the spec that owns the class.
### Task Type
- [x] Testing / QA
### Was this issue authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add unit test coverage for WorkflowExecutionService state events and teardown [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #8033:
URL: https://github.com/apache/texera/issues/8033#issuecomment-5434689198
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @aglinxinyuan!
It looks like the issue description doesn't quite follow our template yet:
- This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add unit test coverage for WorkflowExecutionService state events and teardown [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #8033: Add unit test coverage for WorkflowExecutionService state events and teardown
URL: https://github.com/apache/texera/issues/8033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org