You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/27 00:08:22 UTC

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #2098: [Ballista] Support Union in ballista.

houqp commented on a change in pull request #2098:
URL: https://github.com/apache/arrow-datafusion/pull/2098#discussion_r835826477



##########
File path: datafusion/src/physical_plan/union.rs
##########
@@ -43,7 +43,7 @@ use async_trait::async_trait;
 #[derive(Debug)]
 pub struct UnionExec {
     /// Input execution plan
-    inputs: Vec<Arc<dyn ExecutionPlan>>,
+    pub inputs: Vec<Arc<dyn ExecutionPlan>>,

Review comment:
       better keep it consistent across different physical plans, other plans keep this field private and choose to expose it through an `input` method instead, see the limit plan for an example.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org