You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2025/10/26 16:35:35 UTC

[PR] Preserve BuildSettings property prefixes for BuildSettings properties in forked jvms [grails-core]

codeconsole opened a new pull request, #15173:
URL: https://github.com/apache/grails-core/pull/15173

   Build settings are being prefixed stripped in forked jvms, This prevents that from happening.
   
   `grails.project.target.dir` is turning into `target.dir` in forked jvm which is not a desired outcome.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Preserve BuildSettings property prefixes for BuildSettings properties in forked jvms [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole closed pull request #15173: Preserve BuildSettings property prefixes for BuildSettings properties in forked jvms
URL: https://github.com/apache/grails-core/pull/15173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Preserve BuildSettings property prefixes for BuildSettings properties in forked jvms [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on PR #15173:
URL: https://github.com/apache/grails-core/pull/15173#issuecomment-3448914819

   I could not find any references to stripped versions of `grails.project.` This also fixes these areas if ran in a forked jvm:
   
     1. All Application Command Tasks
   
     - Code: ExecutionContext (ExecutionContext.groovy:44-52)
     final File baseDir = BuildSettings.BASE_DIR
     final File classesDir = BuildSettings.CLASSES_DIR
     final File targetDir = BuildSettings.TARGET_DIR
     - Tasks Affected: Any ApplicationContextCommandTask or ApplicationContextScriptTask
     - Impact: Commands would have wrong paths for:
       - Project base directory
       - Classes output directory
       - Target build directory
     - Examples: Custom Grails commands created by users that access executionContext.targetDir
   
     2. FileSystemInteraction in Commands
   
     - Code: FileSystemInteractionImpl (FileSystemInteractionImpl.groovy:170, 178, 186)
     File getBuildDir() { BuildSettings.TARGET_DIR }
     File getResourcesDir() { BuildSettings.RESOURCES_DIR }
     File getClassesDir() { BuildSettings.CLASSES_DIR }
     - Impact: Any command using fileSystemInteraction.buildDir would get wrong path


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org