You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/10/18 02:34:16 UTC
Review Request 26904: Replace ModuleManager::expandLibraryName with
os::libraries::expandName.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26904/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository: mesos-git
Description
-------
Replace ModuleManager::expandLibraryName with os::libraries::expandName.
Diffs
-----
src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d
src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726
Diff: https://reviews.apache.org/r/26904/diff/
Testing
-------
make check.
Thanks,
Kapil Arya
Re: Review Request 26904: Replace ModuleManager::expandLibraryName
with os::libraries::expandName.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26904/#review57383
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 18, 2014, 12:04 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26904/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2014, 12:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace ModuleManager::expandLibraryName with os::libraries::expandName.
>
>
> Diffs
> -----
>
> src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d
> src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726
>
> Diff: https://reviews.apache.org/r/26904/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26904: Replace ModuleManager::expandLibraryName
with os::libraries::expandName.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26904/
-----------------------------------------------------------
(Updated Oct. 18, 2014, 3:04 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebased diff
Repository: mesos-git
Description
-------
Replace ModuleManager::expandLibraryName with os::libraries::expandName.
Diffs (updated)
-----
src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d
src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726
Diff: https://reviews.apache.org/r/26904/diff/
Testing
-------
make check.
Thanks,
Kapil Arya