You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/18 23:29:00 UTC
[GitHub] [druid] jihoonson opened a new pull request #9535: Do not use
UnmodifiableList in auto compaction
jihoonson opened a new pull request #9535: Do not use UnmodifiableList in auto compaction
URL: https://github.com/apache/druid/pull/9535
### Description
The auto compaction currently fails since the `NewestSegmentFirstIterator` creates an `UnmodifiableList` but the auto compaction needs to sort it.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9535: Fix
UnsupportedOperationException when sorting segments in auto compaction
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9535: Fix UnsupportedOperationException when sorting segments in auto compaction
URL: https://github.com/apache/druid/pull/9535#issuecomment-600923772
@suneet-s I'm thinking to add some in a follow-up PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on issue #9535: Fix
UnsupportedOperationException when sorting segments in auto compaction
Posted by GitBox <gi...@apache.org>.
suneet-s commented on issue #9535: Fix UnsupportedOperationException when sorting segments in auto compaction
URL: https://github.com/apache/druid/pull/9535#issuecomment-600913167
can we add an integration test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #9535: Fix
UnsupportedOperationException when sorting segments in auto compaction
Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #9535: Fix UnsupportedOperationException when sorting segments in auto compaction
URL: https://github.com/apache/druid/pull/9535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on issue #9535: Fix
UnsupportedOperationException when sorting segments in auto compaction
Posted by GitBox <gi...@apache.org>.
suneet-s commented on issue #9535: Fix UnsupportedOperationException when sorting segments in auto compaction
URL: https://github.com/apache/druid/pull/9535#issuecomment-600940592
> @suneet-s I'm thinking to add some in a follow-up PR.
cool. Any reason not to do it in this patch? Is it hard to add an integration test (fwiw - I've been fighting with them for about a day :( )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9535: Fix
UnsupportedOperationException when sorting segments in auto compaction
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9535: Fix UnsupportedOperationException when sorting segments in auto compaction
URL: https://github.com/apache/druid/pull/9535#issuecomment-601351440
@suneet-s yeah, I agree we need some integration tests for the auto compaction. But, I think it's a different issue than fixing this bug. Since we are currently lack of any tests for it, I think it would be better to add a couple of tests required in a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org