[GitHub] [couchdb-rebar] jaydoane commented on a diff in pull request #4: Copy rebar.app before bootstrapping

[GitBox <gi...@apache.org>]

jaydoane commented on code in PR #4:
URL: https://github.com/apache/couchdb-rebar/pull/4#discussion_r1064044623


##########
bootstrap:
##########
@@ -49,6 +49,12 @@ main(Args) ->
                           false -> undefined
                       end,
 
+    %% Ensure, that the ebin folder exists after "make clean"
+    ok = filelib:ensure_dir("ebin/"),
+
+    %% Copy rebar.app into ebin
+    {ok, _} = file:copy("rebar.app", "ebin/rebar.app"),

Review Comment:
   maybe we can add something like e.g. ?
   ```
       %% CouchDB's `make clean` clobbers all ebin directories, so protect rebar.app by
       %%  moving it out of harm's way, and copying it into ebin before building.
   ```



##########
bootstrap:
##########
@@ -49,6 +49,12 @@ main(Args) ->
                           false -> undefined
                       end,
 
+    %% Ensure, that the ebin folder exists after "make clean"
+    ok = filelib:ensure_dir("ebin/"),
+
+    %% Copy rebar.app into ebin
+    {ok, _} = file:copy("rebar.app", "ebin/rebar.app"),

Review Comment:
   maybe we can add something like e.g. ?
   ```
       %% CouchDB's `make clean` clobbers all ebin directories, so protect rebar.app by
       %% moving it out of harm's way, and copying it into ebin before building.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org