You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2017/09/05 18:14:58 UTC
svn commit: r1807383 - in /maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod: JModCreateMojo.java JModHashMojo.java

Author: khmarbaise
Date: Tue Sep  5 18:14:58 2017
New Revision: 1807383

URL: http://svn.apache.org/viewvc?rev=1807383&view=rev
Log:
Cleaned up docs.
Removed some unused parameters.

Modified:
    maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
    maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModHashMojo.java

Modified: maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java?rev=1807383&r1=1807382&r2=1807383&view=diff
==============================================================================
--- maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java (original)
+++ maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java Tue Sep  5 18:14:58 2017
@@ -41,7 +41,6 @@ import org.codehaus.plexus.util.cli.Comm
  * 
  * @author Karl Heinz Marbaise <a href="mailto:khmarbaise@apache.org">khmarbaise@apache.org</a>
  */
-// TODO: Reconsider resolution scope.
 // CHECKSTYLE_OFF: LineLength
 @Mojo( name = "create", requiresDependencyResolution = ResolutionScope.COMPILE, defaultPhase = LifecyclePhase.PACKAGE, requiresProject = true )
 // CHECKSTYLE_ON: LineLength
@@ -119,6 +118,9 @@ public class JModCreateMojo
     @Parameter
     private List<String> excludes;
 
+    /**
+     * Define the main class which is recorded in the <code>module-info.class</code> file.
+     */
     @Parameter
     private String mainClass;
 
@@ -154,7 +156,6 @@ public class JModCreateMojo
     /**
      * Define the modulepath for the <code>jmod</code> call. <code>--module-path &lt;path&gt;</code>
      */
-    // TODO: check if this target/classes folder?
     @Parameter( defaultValue = "${project.build.outputDirectory}", required = true )
     private File modulePath;
 

Modified: maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModHashMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModHashMojo.java?rev=1807383&r1=1807382&r2=1807383&view=diff
==============================================================================
--- maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModHashMojo.java (original)
+++ maven/plugins/trunk/maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModHashMojo.java Tue Sep  5 18:14:58 2017
@@ -78,24 +78,6 @@ public class JModHashMojo
     private String moduleVersion;
 
     /**
-     * <code>--os-arch &lt;os-arch&gt;</code> Operating system architecture.
-     */
-    @Parameter
-    private String osArch;
-
-    /**
-     * <code>--os-name &lt;os-name&gt;</code> Operating system name.
-     */
-    @Parameter
-    private String osName;
-
-    /**
-     * <code>--os-version &lt;os-version&gt;</code> Operating system version.
-     */
-    @Parameter
-    private String osVersion;
-
-    /**
      * Define the modulepath for the <code>jmod</code> call. <code>--module-path &lt;path&gt;</code>
      * Must be a directory.
      */