You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "nfsantos (via GitHub)" <gi...@apache.org> on 2024/07/25 14:35:49 UTC
[PR] OAK-10976 - Avoid unnecessary call to PathUtils.getName in IndexDefinition [jackrabbit-oak]
nfsantos opened a new pull request, #1603:
URL: https://github.com/apache/jackrabbit-oak/pull/1603
In NamePattern.matches(), do not compute the property name if the parent path does not match. This avoids an unnecessary call to PathUtils.getName() in the parentPath do not match. This logic is in the critical path of indexing.
Other fixes:
- replace Guava usages with JDK equivalents
- fix typos
- improve formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10976 - Avoid unnecessary call to PathUtils.getName in IndexDefinition [jackrabbit-oak]
Posted by "nfsantos (via GitHub)" <gi...@apache.org>.
nfsantos merged PR #1603:
URL: https://github.com/apache/jackrabbit-oak/pull/1603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10976 - Avoid unnecessary call to PathUtils.getName in IndexDefinition [jackrabbit-oak]
Posted by "nfsantos (via GitHub)" <gi...@apache.org>.
nfsantos commented on PR #1603:
URL: https://github.com/apache/jackrabbit-oak/pull/1603#issuecomment-2250621834
> I'd prefer to split this into two PRs, if possible.
>
> See https://jackrabbit.apache.org/oak/docs/participating.html#making-changes
Done: https://github.com/apache/jackrabbit-oak/pull/1604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10976 - Avoid unnecessary call to PathUtils.getName in IndexDefinition [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #1603:
URL: https://github.com/apache/jackrabbit-oak/pull/1603#issuecomment-2250529584
I'd prefer to split this into two PRs, if possible.
See https://jackrabbit.apache.org/oak/docs/participating.html#making-changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org