You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by koeninger <gi...@git.apache.org> on 2017/04/18 21:19:13 UTC

[GitHub] spark pull request #17675: [SPARK-20036][DOC] Note incompatible dependencies...

GitHub user koeninger opened a pull request:

    https://github.com/apache/spark/pull/17675

    [SPARK-20036][DOC] Note incompatible dependencies on org.apache.kafka artifacts

    
    ## What changes were proposed in this pull request?
    
    Note that you shouldn't manually add dependencies on org.apache.kafka artifacts
    
    ## How was this patch tested?
    
    Doc only change, did jekyll build and looked at the page.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/koeninger/spark-1 SPARK-20036

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17675
    
----
commit bcba5bac51aea773616fda539a9a1e48604a7815
Author: cody koeninger <co...@koeninger.org>
Date:   2017-04-18T21:16:14Z

    [SPARK-20036][DOC] Document that you shouldnt add incompatible dependencies on org.apache.kafka artifacts

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    **[Test build #75915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75915/testReport)** for PR 17675 at commit [`be55fd5`](https://github.com/apache/spark/commit/be55fd5c0023105a77c5870fb8ffcfb21c0759a0).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75915/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    **[Test build #75913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75913/testReport)** for PR 17675 at commit [`bcba5ba`](https://github.com/apache/spark/commit/bcba5bac51aea773616fda539a9a1e48604a7815).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    **[Test build #75913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75913/testReport)** for PR 17675 at commit [`bcba5ba`](https://github.com/apache/spark/commit/bcba5bac51aea773616fda539a9a1e48604a7815).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75913/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    **[Test build #75915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75915/testReport)** for PR 17675 at commit [`be55fd5`](https://github.com/apache/spark/commit/be55fd5c0023105a77c5870fb8ffcfb21c0759a0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17675: [SPARK-20036][DOC] Note incompatible dependencies...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/17675


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17675: [SPARK-20036][DOC] Note incompatible dependencies on org...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17675
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17675: [SPARK-20036][DOC] Note incompatible dependencies...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17675#discussion_r112068489
  
    --- Diff: docs/streaming-kafka-0-10-integration.md ---
    @@ -12,6 +12,8 @@ For Scala/Java applications using SBT/Maven project definitions, link your strea
     	artifactId = spark-streaming-kafka-0-10_{{site.SCALA_BINARY_VERSION}}
     	version = {{site.SPARK_VERSION_SHORT}}
     
    +**Do not** manually add dependencies on org.apache.kafka artifacts (e.g. kafka-clients).  The spark-streaming-kafka-0-10 artifact has the appropriate transitive dependencies already, and different versions may be incompatible in hard to diagnose ways.
    --- End diff --
    
    I suppose that if the app is using kafka APIs directly it should declare a direct dependency on it, but, harmonize the versions. That said, that's error prone, so this seems OK. If you make further changes to the text here can you back-tick the artifact names for readability?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org