You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/09/25 15:47:30 UTC

[GitHub] tinkerpop pull request #940: TINKERPOP-2039 Bump to Groovy 2.5.2

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/940

    TINKERPOP-2039 Bump to Groovy 2.5.2

    https://issues.apache.org/jira/browse/TINKERPOP-2039
    
    Required some minor changes to the Console as the CliBuilder is no longer the recommended approach for Groovy - had to use picocli classes instead. Still couldn't make the command line parsing work exclusively under picocli - I think we have somewhat nonstandard options in our command line.
    
    Performed manual tests and builds with `mvn clean install && mvn verify -pl gremlin-console -DskipIntegrationTests=false`.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-2039

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #940
    
----
commit 0c2347b535e2120c72278b011fe3dce0ec36bdf5
Author: Stephen Mallette <sp...@...>
Date:   2018-09-19T14:50:20Z

    TINKERPOP-2039 Bump to Groovy 2.5.2
    
    Required some minor changes to the Console as the CliBuilder is no longer the recommended approach for Groovy - had to use picocli classes instead. Still couldn't make the command line parsing work exclusively under picocli - I think we have somewhat nonstandard options in our command line.

----


---

[GitHub] tinkerpop issue #940: TINKERPOP-2039 Bump to Groovy 2.5.2

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/940
  
    sorry - i merged this ahead of the cool down period. i did it over 3 days rather than the 1 week. got my days mixed up. please let me know if this was a problem for anyone.


---

[GitHub] tinkerpop pull request #940: TINKERPOP-2039 Bump to Groovy 2.5.2

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/940


---