You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/10/18 02:34:44 UTC

[jira] Created: (HADOOP-4453) Improve ssl handling for distcp

Improve ssl handling for distcp
-------------------------------

                 Key: HADOOP-4453
                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
             Project: Hadoop Core
          Issue Type: Improvement
          Components: dfs
    Affects Versions: 0.20.0
            Reporter: Chris Douglas
             Fix For: 0.20.0


HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4453:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Kan

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch, 4453-4.patch, 4453-5.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641972#action_12641972 ] 

Kan Zhang commented on HADOOP-4453:
-----------------------------------

SSL properties are system properties that affect all SSL connections that the client make, not just those used in HsftpFileSystem.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Attachment: 4453-2.patch

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641990#action_12641990 ] 

Chris Douglas commented on HADOOP-4453:
---------------------------------------

bq. SSL properties are system properties that affect all SSL connections that the client make, not just those used in HsftpFileSystem. 

This is a good point, but it also highlights the extent of this change. Since the purpose of this JIRA is to improve the existing ssl support for HsftpFileSystem, its side-effects shouldn't extend to all map/reduce tasks. Ideally, it should also maintain distcp's FileSystem agnosticism.

The server code looks good. The client code in Child and DistCp can probably be moved into HsftpFileSystem::initialize, which should also warn if it's called more than once in the same JVM (assuming a second HsftpFileSystem handle can invalidate the first; FileSystem cache hits should be benign). Unfortunately, this creates a dilemma for distcp: its client and task resources may be at different locations, but HsftpFileSystem will use the same property. This is going to be true for many users of HsftpFileSystem.

Lacking a general need for similar, asymmetric configuration, I'd propose adding a static config method to HsftpFileSystem:
{code}

public static void setSslConfigLocation(String loc, Configuration conf) {
  conf.set("dfs.https.client.keystore.resource", loc);
}
{code}

And calling this before submitting the job from DistCp, if {{\-mapredSslLoc <loc>}} is specified. If there is a general need, we can look into extending GenericOptionsParser to support something more clever.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4453:
----------------------------------

    Attachment: 4453-0.patch

Attaching ssl-related section of 4284 on Kan's behalf.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Attachment:     (was: 4453-3.patch)

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Attachment: 4453-3.patch

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646001#action_12646001 ] 

Hudson commented on HADOOP-4453:
--------------------------------

Integrated in Hadoop-trunk #655 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/655/])
    . Improve ssl configuration and handling in HsftpFileSystem,
particularly when used with DistCp. Contributed by Kan Zhang.


> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch, 4453-4.patch, 4453-5.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Status: Patch Available  (was: Open)

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4453:
----------------------------------

    Attachment: 4453-5.patch

HADOOP-4575 conflicted with this patch; this is the diff committed to trunk.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch, 4453-4.patch, 4453-5.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645878#action_12645878 ] 

Chris Douglas commented on HADOOP-4453:
---------------------------------------

Hsftp::initialize should call {{super.initialize(name, conf);}} instead of repeating code from Hftp::initialize, but otherwise +1

Has this been tested with with FsShell?

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Attachment: 4453-3.patch

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645699#action_12645699 ] 

Kan Zhang commented on HADOOP-4453:
-----------------------------------

Though I'm not fully convinced, I attached a new patch that follows Chris' suggestion.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641960#action_12641960 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4453:
------------------------------------------------

setupSsl(...) should not be done in DistCp since DistCp should only uses file system API.   How about move the codes to HsftpFileSystem, so that these codes will be executed when a HsftpFileSystem is initialized?

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas reassigned HADOOP-4453:
-------------------------------------

    Assignee: Kan Zhang

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Status: Open  (was: Patch Available)

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645893#action_12645893 ] 

Kan Zhang commented on HADOOP-4453:
-----------------------------------

> Hsftp::initialize should call super.initialize(name, conf);
corrected in the new patch.

> Has this been tested with with FsShell?
Yes.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch, 4453-4.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640743#action_12640743 ] 

Kan Zhang commented on HADOOP-4453:
-----------------------------------

Chris, thanks for helping me splitting the patch!

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641058#action_12641058 ] 

Hadoop QA commented on HADOOP-4453:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12392402/4453-2.patch
  against trunk revision 705942.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3496/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3496/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3496/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3496/console

This message is automatically generated.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Attachment: 4453-4.patch

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch, 4453-4.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-4453:
------------------------------

    Status: Patch Available  (was: Open)

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4453) Improve ssl handling for distcp

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645873#action_12645873 ] 

Hadoop QA commented on HADOOP-4453:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12393492/4453-3.patch
  against trunk revision 712102.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3550/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3550/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3550/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3550/console

This message is automatically generated.

> Improve ssl handling for distcp
> -------------------------------
>
>                 Key: HADOOP-4453
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4453
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Chris Douglas
>            Assignee: Kan Zhang
>             Fix For: 0.20.0
>
>         Attachments: 4453-0.patch, 4453-2.patch, 4453-3.patch
>
>
> HsftpFileSystem is an ad hoc way to read from HDFS over ssl, targeting distcp. Its organization can be improved and its support of ssl features expanded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.