You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/05 22:04:53 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27034:
[SPARK-30122][K8S] Support
spark.kubernetes.authenticate.executor.serviceAccountName
dongjoon-hyun commented on a change in pull request #27034: [SPARK-30122][K8S] Support spark.kubernetes.authenticate.executor.serviceAccountName
URL: https://github.com/apache/spark/pull/27034#discussion_r375534441
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStep.scala
##########
@@ -17,19 +17,23 @@
package org.apache.spark.deploy.k8s.features
import org.apache.spark.deploy.k8s.{KubernetesConf, SparkPod}
-import org.apache.spark.deploy.k8s.Config.KUBERNETES_SERVICE_ACCOUNT_NAME
+import org.apache.spark.deploy.k8s.Config.{KUBERNETES_DRIVER_SERVICE_ACCOUNT_NAME, KUBERNETES_EXECUTOR_SERVICE_ACCOUNT_NAME}
import org.apache.spark.deploy.k8s.KubernetesUtils.buildPodWithServiceAccount
private[spark] class ExecutorKubernetesCredentialsFeatureStep(kubernetesConf: KubernetesConf)
extends KubernetesFeatureConfigStep {
- private lazy val driverServiceAccount = kubernetesConf.get(KUBERNETES_SERVICE_ACCOUNT_NAME)
+
+ private lazy val driverServiceAccount = kubernetesConf.get(KUBERNETES_DRIVER_SERVICE_ACCOUNT_NAME)
+ private lazy val executorServiceAccount =
+ kubernetesConf.get(KUBERNETES_EXECUTOR_SERVICE_ACCOUNT_NAME)
override def configurePod(pod: SparkPod): SparkPod = {
pod.copy(
- // if not setup by the pod template fallback to the driver's sa,
- // last option is the default sa.
+ // if not setup by the pod template, fallback to the executor's sa,
+ // if executor's sa is not setup, the last option is driver's sa.
pod = if (Option(pod.pod.getSpec.getServiceAccount).isEmpty) {
- buildPodWithServiceAccount(driverServiceAccount, pod).getOrElse(pod.pod)
Review comment:
Hi, @liyinan926 . The current behavior is fallback to `driverServiceAccount` first, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org