You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/18 02:20:42 UTC

[GitHub] [pulsar] Shawyeok commented on a change in pull request #14348: Expose BookKeeper client thread pool metrics

Shawyeok commented on a change in pull request #14348:
URL: https://github.com/apache/pulsar/pull/14348#discussion_r809623165



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java
##########
@@ -93,7 +93,7 @@ public void initialize(ServiceConfiguration conf, MetadataStoreExtended metadata
                     try {
                         return bookkeeperProvider.create(conf, metadataStore, eventLoopGroup,
                                 Optional.ofNullable(ensemblePlacementPolicyConfig.getPolicyClass()),
-                                ensemblePlacementPolicyConfig.getProperties());
+                                ensemblePlacementPolicyConfig.getProperties(), statsLogger);

Review comment:
       It may introduce another problem here, duplicate metrics owned by different `OrderedExecutors`, cannot figure which thread if a metric goes wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org