You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/06/09 18:44:22 UTC

[GitHub] [mesos] cf-natali commented on pull request #392: Updated picojson to version 1.3.1-dev.

cf-natali commented on pull request #392:
URL: https://github.com/apache/mesos/pull/392#issuecomment-857971389


   Yes I was wondering about that, but:
   - the patch doesn't apply cleanly, because in the meantime they've reformatted the code
   - updating would allow us to get rid of this patch we maintain ourselves
   - I think the patch we currently apply is actually incomplete, upstream has a subsequent fix applied more recently: https://github.com/kazuho/picojson/commit/35ce0b6b03e0b60541258f5ad061003a696d9a34
   
   So I can definitely apply the one-line change to our patch, just want to make sure that's the preferred option - @asekretenko  ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org