You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@brpc.apache.org by "zhoukangsheng (via GitHub)" <gi...@apache.org> on 2025/09/21 09:00:33 UTC
[I] 升级到1.10.0版本后，ServerOptions中的num_threads设置失效了 (brpc)
zhoukangsheng opened a new issue, #3100:
URL: https://github.com/apache/brpc/issues/3100
**Describe the bug**
有个服务从0.9.7升级到1.10.0版本后，发现耗时上涨，经过初步排查，发现ServerOptions中的num_threads设置值为的48，但是通过flags服务查看到 bthread_concurrency的值依旧为9（默认初始值），回退到0.9.7版本耗时正常，bthread_concurrency的值为48。
**To Reproduce**
**Expected behavior**
**Versions**
OS:
Compiler:
brpc: 1.10.0
protobuf:
**Additional context/screenshots**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For additional commands, e-mail: issues-help@brpc.apache.org
Re: [I] 升级到1.10.0版本后，ServerOptions中的num_threads设置失效了 (brpc)
Posted by "zhoukangsheng (via GitHub)" <gi...@apache.org>.
zhoukangsheng commented on issue #3100:
URL: https://github.com/apache/brpc/issues/3100#issuecomment-3317780248
原因找到了，先说结论，是1.10.0版本 https://github.com/apache/brpc/pull/2628/files 引入的问题，并且在1.12.0版本https://github.com/apache/brpc/pull/2801/files 将这个问题修复了。具体原因是
<img width="1876" height="744" alt="Image" src="https://github.com/user-attachments/assets/3ae69d2c-64e8-4975-b899-776fc7feab8d" />
<img width="1159" height="828" alt="Image" src="https://github.com/user-attachments/assets/5a7e3117-0d2b-415a-a03a-23c91458efb7" /> 在1.10.0之前，bthread_concurrency一直使用的是默认值，线上服务通过ServerOptions的num_threads设置的线程数，升级到1.10.0版本后，由于上述commit，导致num_threads大于bthread_concurrency的默认值时，会直接被判断无效
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For additional commands, e-mail: issues-help@brpc.apache.org
Re: [I] 升级到1.10.0版本后，ServerOptions中的num_threads设置失效了 (brpc)
Posted by "zhoukangsheng (via GitHub)" <gi...@apache.org>.
zhoukangsheng commented on issue #3100:
URL: https://github.com/apache/brpc/issues/3100#issuecomment-3322639362
> 那现在这个是否还有问题？
把1.12.0版本对应的commit cherry-pick来之后没问题了。我一会儿把这个issue关了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For additional commands, e-mail: issues-help@brpc.apache.org
Re: [I] 升级到1.10.0版本后，ServerOptions中的num_threads设置失效了 (brpc)
Posted by "yanglimingcn (via GitHub)" <gi...@apache.org>.
yanglimingcn commented on issue #3100:
URL: https://github.com/apache/brpc/issues/3100#issuecomment-3322627107
那现在这个是否还有问题？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For additional commands, e-mail: issues-help@brpc.apache.org
Re: [I] 升级到1.10.0版本后，ServerOptions中的num_threads设置失效了 (brpc)
Posted by "zhoukangsheng (via GitHub)" <gi...@apache.org>.
zhoukangsheng closed issue #3100: 升级到1.10.0版本后，ServerOptions中的num_threads设置失效了
URL: https://github.com/apache/brpc/issues/3100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For additional commands, e-mail: issues-help@brpc.apache.org
Re: [I] 升级到1.10.0版本后，ServerOptions中的num_threads设置失效了 (brpc)
Posted by "zhoukangsheng (via GitHub)" <gi...@apache.org>.
zhoukangsheng commented on issue #3100:
URL: https://github.com/apache/brpc/issues/3100#issuecomment-3317740340
原因找到了，先说结论：1.10.0版本
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@brpc.apache.org
For additional commands, e-mail: issues-help@brpc.apache.org