You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2012/01/07 23:47:57 UTC
svn commit: r1228749 - in
/hbase/trunk/src/main/java/org/apache/hadoop/hbase: ipc/HBaseServer.java
monitoring/MonitoredRPCHandlerImpl.java
Author: stack
Date: Sat Jan 7 22:47:56 2012
New Revision: 1228749
URL: http://svn.apache.org/viewvc?rev=1228749&view=rev
Log:
HBASE-5141 Memory leak in MonitoredRPCHandlerImpl -- REDO
Modified:
hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
hbase/trunk/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
Modified: hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
URL: http://svn.apache.org/viewvc/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java?rev=1228749&r1=1228748&r2=1228749&view=diff
==============================================================================
--- hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java (original)
+++ hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java Sat Jan 7 22:47:56 2012
@@ -1343,6 +1343,7 @@ public abstract class HBaseServer implem
errorClass, error);
}
call.sendResponseIfReady();
+ status.markComplete("Sent response");
} catch (InterruptedException e) {
if (running) { // unexpected -- log it
LOG.info(getName() + " caught: " +
Modified: hbase/trunk/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
URL: http://svn.apache.org/viewvc/hbase/trunk/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java?rev=1228749&r1=1228748&r2=1228749&view=diff
==============================================================================
--- hbase/trunk/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java (original)
+++ hbase/trunk/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java Sat Jan 7 22:47:56 2012
@@ -217,6 +217,13 @@ public class MonitoredRPCHandlerImpl ext
this.remotePort = remotePort;
}
+ @Override
+ public void markComplete(String status) {
+ super.markComplete(status);
+ this.params = null;
+ this.packet = null;
+ }
+
public synchronized Map<String, Object> toMap() {
// only include RPC info if the Handler is actively servicing an RPC call
Map<String, Object> map = super.toMap();