You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/05 17:02:49 UTC

[GitHub] [kafka] abbccdda commented on a change in pull request #8816: MINOR: Print all members during join complete

abbccdda commented on a change in pull request #8816:
URL: https://github.com/apache/kafka/pull/8816#discussion_r436048713



##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -1150,7 +1150,6 @@ class GroupCoordinator(val brokerId: Int,
       group.notYetRejoinedMembers.filterNot(_.isStaticMember) foreach { failedMember =>
         removeHeartbeatForLeavingMember(group, failedMember)
         group.remove(failedMember.memberId)
-        group.removeStaticMember(failedMember.groupInstanceId)

Review comment:
       This is a cleanup. In the current logic we should never hit a static member in this block




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org