[GitHub] [pulsar] nodece commented on a change in pull request #14225: [Broker] Move schema compatibility strategy cmd from topics to topicPolicies

[GitBox <gi...@apache.org>]

nodece commented on a change in pull request #14225:
URL: https://github.com/apache/pulsar/pull/14225#discussion_r805128880



##########
File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/cli/topicpolicies/SchemaCompatibilityStrategyTest.java
##########
@@ -19,67 +19,53 @@
 
 package org.apache.pulsar.tests.integration.cli.topicpolicies;
 
-import static org.testng.Assert.assertTrue;
+import static org.testng.Assert.assertEquals;
 import org.apache.pulsar.common.policies.data.SchemaCompatibilityStrategy;
 import org.apache.pulsar.tests.integration.docker.ContainerExecResult;
 import org.apache.pulsar.tests.integration.suites.PulsarTestSuite;
 import org.awaitility.Awaitility;
 import org.testng.annotations.Test;
 
 public class SchemaCompatibilityStrategyTest extends PulsarTestSuite {
-    @Override
-    public void setupCluster() throws Exception {
-        super.setupCluster();
-    }
-
-    @Override
-    public void tearDownCluster() throws Exception {
-        super.tearDownCluster();
-    }
-
     @Test
-    public void testSchemaCompatibilityCmd() throws Exception {
-        String topicName = generateTopicName("",true);
+    public void testSchemaCompatibilityStrategyCmd() throws Exception {
+        String topicName = generateTopicName("test-schema-compatibility-strategy", true);
         pulsarAdmin.topics().createNonPartitionedTopic(topicName);
 
-        Awaitility.await().untilAsserted(()->{

Review comment:
       Only topic policies are asynchronous in Pulsar,  so I remove this`Awaitility`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org